From e6c78f51e895cb0d08f427721d01d1909b4c92a8 Mon Sep 17 00:00:00 2001 From: girst Date: Sun, 6 Mar 2022 02:28:53 +0100 Subject: [PATCH] Revert "automatically disable signature requirement" downgrading the warning color stopped working some time ago. for completeness, as of nightly99 xpinstall.signatures.required is only checked in these places, none of which affect us: - nsContentSecurityUtils.cpp::DetectJsHacks() only for telemetry and relaxing some security measures we don't need - BrowserGlue.jsm::_onWindowsRestored() gates call to _notifyUnsignedAddonsDisabled(), which isn't triggered by our stuff (signedState != SIGNEDSTATE_MISSING) - AddonSettings.jsm::REQUIRE_SIGNING overridden by our config.js script, so doesn't matter - XPIProvider.jsm::observe() calls XPIDatabase.updateAddonAppDisabledStates(), which calls this.updateAddonDisabledState(addon), which depends on this.isUsableAddon(aAddon), which returns true as long as we override this.isDisabledLegacy(aAddon) This reverts commit 29dc0ab3a8f8bd6e781fb983cd076764480dce18. --- config.js | 3 --- 1 file changed, 3 deletions(-) diff --git a/config.js b/config.js index 8919be4..6a7fea1 100644 --- a/config.js +++ b/config.js @@ -16,9 +16,6 @@ try { const {AddonManager} = Cu.import('resource://gre/modules/AddonManager.jsm'); const {BootstrapLoader} = Cu.import('resource://legacy/BootstrapLoader.jsm'); AddonManager.addExternalExtensionLoader(BootstrapLoader); - - const {Services} = Cu.import('resource://gre/modules/Services.jsm'); - Services.prefs.setBoolPref('xpinstall.signatures.required', false); } catch(ex) { Components.utils.reportError(ex.message); } -- 2.39.3