From 00b5d9164199cdaade5d4bb7e909e68a5706b8a0 Mon Sep 17 00:00:00 2001 From: Simon Lydell Date: Sat, 7 Sep 2013 12:37:24 +0200 Subject: [PATCH] Fix: commit 586dd356 broke hint marker rotation --- extension/packages/hints.coffee | 8 ++++++-- extension/packages/marker.coffee | 2 -- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/extension/packages/hints.coffee b/extension/packages/hints.coffee index 35c444a..b67c03d 100644 --- a/extension/packages/hints.coffee +++ b/extension/packages/hints.coffee @@ -49,7 +49,7 @@ removeHints = (document) -> removeHints(frame.document) -# Like `injectMarkers`, but also sets hints for the markers +# Like `insertHints`, but also sets hints for the markers injectHints = (document) -> markers = createMarkers(document) hintChars = utils.getHintChars() @@ -59,6 +59,10 @@ injectHints = (document) -> removeHints(document) insertHints(markers) + # Must be done after the hints have been inserted into the DOM (see marker.coffee) + for marker in markers + marker.completePosition() + return markers insertHints = (markers) -> @@ -73,7 +77,7 @@ insertHints = (markers) -> doc = marker.element.ownerDocument if not getFrag(doc) docFrags.push([doc, doc.createDocumentFragment()]) - + frag = getFrag(doc) frag.appendChild(marker.markerElement) diff --git a/extension/packages/marker.coffee b/extension/packages/marker.coffee index 136b97f..98f075b 100644 --- a/extension/packages/marker.coffee +++ b/extension/packages/marker.coffee @@ -70,8 +70,6 @@ class Marker @markerElement.appendChild(fragment) - @completePosition() - # Add another char to the `enteredHintString`, # see if it still matches `hintString`, apply classes to # the distinct hint characters and show/hide marker when -- 2.39.3