From 1791f88921cb8b87467782df6c5f10bf2e721eab Mon Sep 17 00:00:00 2001 From: girst Date: Sat, 19 Oct 2019 19:33:08 +0200 Subject: [PATCH] fix 'eb' for fx71 browser.xhtml was restructured between firefox 69 and 71, and hints were not displaying any more (they still worked, adding to the confusion). It turns out that moving the hints-containert before #navigator-toolbox is sufficient. But insertBefore()ing that element breaks Waterfox 56, as this element does not exist there (which is a bit strange, as the docs say, insertBefore should degrade gracefully to appendChild in such a case). However, we can just insert it as the first element below the #main-window element, which works a treat. --- extension/lib/commands.coffee | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/extension/lib/commands.coffee b/extension/lib/commands.coffee index 418b3c2..dd9030e 100644 --- a/extension/lib/commands.coffee +++ b/extension/lib/commands.coffee @@ -736,8 +736,10 @@ commands.click_browser_element = ({vim}) -> }) MarkerContainer.remove(window) # Better safe than sorry. markerContainer.container.classList.add('ui') - window.document.getElementById('main-window').appendChild( - markerContainer.container + mainWindow = window.document.getElementById('main-window') + mainWindow.insertBefore( + markerContainer.container, + mainWindow.firstChild ) [firstWrappers, secondWrappers] = -- 2.39.3