From 361b92767fec23edf744112e8e4b586d0bc9d9e9 Mon Sep 17 00:00:00 2001 From: Simon Lydell Date: Sun, 18 Sep 2016 12:27:13 +0200 Subject: [PATCH] Improve error messages for the import prefs button - Don't show "0 options imported successfully". That's confusing. - Add an empty line between error messages. --- extension/lib/prefs-bulk.coffee | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/extension/lib/prefs-bulk.coffee b/extension/lib/prefs-bulk.coffee index a02152a..cd50185 100644 --- a/extension/lib/prefs-bulk.coffee +++ b/extension/lib/prefs-bulk.coffee @@ -73,7 +73,7 @@ importExported = (exportedString) -> createImportErrorReport = ({numSuccesses, errors}) -> header = - if numSuccesses == -1 + if numSuccesses <= 0 'The stuff you entered is invalid:' else s1 = if numSuccesses == 1 then '' else 's' @@ -81,13 +81,13 @@ createImportErrorReport = ({numSuccesses, errors}) -> """ #{numSuccesses} option#{s1} imported successfully. - #{errors.length} error#{s2} occurred: + #{errors.length} error#{s2} also occurred: """ return """ #{header} - #{errors.join('\n')} + #{errors.join('\n\n')} """ module.exports = { -- 2.39.3