From 3647a279e04d4d702f0eb4aad0948d9d5ac814d0 Mon Sep 17 00:00:00 2001 From: Simon Lydell Date: Wed, 14 Sep 2016 18:12:36 +0200 Subject: [PATCH] Fix a case of being unable to filter hints by text 1. Disable the `hints.auto_activate` option. 2. Press `f`. 3. Filter hint markers by element text until only one link matches. 4. Press ``. 5. Try to filter by element text again. Result: Nothing happens. Previously, we got stuck in the `isMatched` mode after deleting a typed char. --- extension/lib/marker-container.coffee | 4 ++-- extension/lib/modes.coffee | 5 ++++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/extension/lib/marker-container.coffee b/extension/lib/marker-container.coffee index 15bd84b..71fa2fb 100644 --- a/extension/lib/marker-container.coffee +++ b/extension/lib/marker-container.coffee @@ -372,7 +372,7 @@ class MarkerContainer @enteredHint = hint @updateVisualFeedback(matchingMarkers) - return true + return matchingMarkers deleteTextChar: -> return false if @enteredText == '' @@ -392,7 +392,7 @@ class MarkerContainer @enteredText = text @updateVisualFeedback(matchingMarkers) - return true + return matchingMarkers updateVisualFeedback: (matchingMarkers) -> @visualFeedbackUpdater?(this, matchingMarkers) diff --git a/extension/lib/modes.coffee b/extension/lib/modes.coffee index 7a76eba..0bee23c 100644 --- a/extension/lib/modes.coffee +++ b/extension/lib/modes.coffee @@ -278,7 +278,10 @@ mode('hints', { storage.markerContainer.rotateOverlapping(false) delete_char: ({storage}) -> - storage.markerContainer.deleteChar() + {markerContainer} = storage + visibleMarkers = markerContainer.deleteChar() + storage.isMatched = + hintsMode.isMatched(visibleMarkers or [], markerContainer) increase_count: ({storage}) -> storage.count += 1 -- 2.39.3