From 562a0cb9b8780ebc8acf67eb3be8c695b58c1506 Mon Sep 17 00:00:00 2001 From: Simon Lydell Date: Wed, 9 Mar 2016 10:20:16 +0100 Subject: [PATCH] Always trigger only 'mousedown' events on XUL tab elements Previously, this was only done for the main browser tabs. It appears that the same treatment is needed for ``s in `about:preferences`. --- extension/lib/commands-frame.coffee | 7 ++++++- extension/lib/commands.coffee | 2 +- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/extension/lib/commands-frame.coffee b/extension/lib/commands-frame.coffee index c12165f..f5b7858 100644 --- a/extension/lib/commands-frame.coffee +++ b/extension/lib/commands-frame.coffee @@ -298,7 +298,12 @@ commands.click_marker_element = (args) -> element.click() else isXUL = (element.ownerDocument instanceof XULDocument) - utils.simulateMouseEvents(element, if isXUL then 'click-xul' else 'click') + sequence = + if isXUL + if element.localName == 'tab' then ['mousedown'] else 'click-xul' + else + 'click' + utils.simulateMouseEvents(element, sequence) element.target = targetReset if targetReset commands.copy_marker_element = ({vim, elementIndex, property}) -> diff --git a/extension/lib/commands.coffee b/extension/lib/commands.coffee index ed1a0bc..ff60390 100644 --- a/extension/lib/commands.coffee +++ b/extension/lib/commands.coffee @@ -520,7 +520,7 @@ commands.click_browser_element = ({vim}) -> utils.focusElement(element, {flag: 'FLAG_BYKEY'}) when 'clickable' sequence = - if element.classList?.contains('tabbrowser-tab') + if element.localName == 'tab' ['mousedown'] else 'click-xul' -- 2.39.3