From 59cb2a9a72a0c39dbf1df9eee3f77755f16de08f Mon Sep 17 00:00:00 2001 From: Simon Lydell Date: Thu, 12 Nov 2015 22:46:22 +0100 Subject: [PATCH] Revert "Remove unnecessary code in commands.follow{,_focus}" This reverts commit 1a77a5d62036ee0d6029b36ee3c2ef33355b0d85. Apparently, I must be wrong. I get a hint marker for the entire page (if it is scrollable) after this commit. So confused now. --- extension/lib/commands-frame.coffee | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/extension/lib/commands-frame.coffee b/extension/lib/commands-frame.coffee index fab96fa..9f10861 100644 --- a/extension/lib/commands-frame.coffee +++ b/extension/lib/commands-frame.coffee @@ -102,7 +102,8 @@ commands.follow = ({ vim, storage }) -> type = 'clickable' unless isXUL or element.nodeName in ['A', 'INPUT', 'BUTTON'] semantic = false - when vim.state.scrollableElements.has(element) + when element != document.documentElement and + vim.state.scrollableElements.has(element) type = 'scrollable' when element.hasAttribute('onclick') or element.hasAttribute('onmousedown') or @@ -191,7 +192,8 @@ commands.follow_focus = ({ vim, storage }) -> type = switch when element.tabIndex > -1 'focusable' - when vim.state.scrollableElements.has(element) + when element != element.ownerDocument.documentElement and + vim.state.scrollableElements.has(element) 'scrollable' return unless type return unless shape = getElementShape(element) -- 2.39.3