From 71a6d3c092d8b86bf868e4ebce0ec73d6df8957f Mon Sep 17 00:00:00 2001 From: girst Date: Sun, 1 Dec 2019 21:23:28 +0100 Subject: [PATCH] fix 'modifiers is null' TypeError element.getAttribute() might return null, while xulElement.getAttribute() returns the empty string. the latter is expected by the implementation. Since fx71, the main window is now an HTMLDocument instead of a XULDocument, causing the breakage. See also: commitmsg of 1791f889 --- extension/lib/events.coffee | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/extension/lib/events.coffee b/extension/lib/events.coffee index 90416dd..5e9e4ec 100644 --- a/extension/lib/events.coffee +++ b/extension/lib/events.coffee @@ -238,7 +238,7 @@ class UIEventManager mainWindow = @window.document.documentElement modifiers = if filterCurrentOnly - mainWindow.getAttribute(HELD_MODIFIERS_ATTRIBUTE) + mainWindow.getAttribute(HELD_MODIFIERS_ATTRIBUTE) or '' else if @suppress == null then 'alt ctrl meta shift' else '' isHeld = (modifier) -> event["#{modifier}Key"] -- 2.39.3