From 7bc6a6683a93a8a1b914e9ac07ecb895eb606f10 Mon Sep 17 00:00:00 2001 From: Simon Lydell Date: Sun, 24 Jan 2016 10:22:55 +0100 Subject: [PATCH] Remove check for 'close' class for clickable elements It gave too many false positives because of the word 'closed' in many classes. Instead of trying to switch to a regex to avoid those cases, I'm trying to completely remove the check. Hopefully the other matching rules are enough. --- extension/lib/commands-frame.coffee | 1 - 1 file changed, 1 deletion(-) diff --git a/extension/lib/commands-frame.coffee b/extension/lib/commands-frame.coffee index 3700854..aefc154 100644 --- a/extension/lib/commands-frame.coffee +++ b/extension/lib/commands-frame.coffee @@ -210,7 +210,6 @@ commands.follow = helper_follow.bind(null, {id: 'normal'}, # waste time on them. element not in [document.documentElement, document.body]) and (utils.includes(element.className, 'button') or - utils.includes(element.className, 'close') or utils.includes(element.getAttribute('aria-label'), 'close') or # Do this last as it’s a potentially expensive check. utils.hasEventListeners(element, 'click')) -- 2.39.3