From 99f29d4ee6f1e822f6d78dc3a09a31f9fa487fee Mon Sep 17 00:00:00 2001 From: Anton Khodakivskiy Date: Thu, 12 Jun 2014 16:40:33 -0700 Subject: [PATCH] fix recursion in isElementGoogleEditable impl --- extension/packages/utils.coffee | 2 +- extension/packages/vim.coffee | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/extension/packages/utils.coffee b/extension/packages/utils.coffee index dda49e9..a760ca3 100644 --- a/extension/packages/utils.coffee +++ b/extension/packages/utils.coffee @@ -85,7 +85,7 @@ isElementEditable = (element) -> # Non-standard attribute commonly used by Google. isElementGoogleEditable = (element) -> element.getAttribute?('g_editable') == 'true' or \ - (element instanceof HTMLElement and isElementGoogleEditable(element.ownerDocument.body)) + (element instanceof HTMLElement and element.ownerDocument.body?.getAttribute('g_editable') == 'true') isElementVisible = (element) -> document = element.ownerDocument diff --git a/extension/packages/vim.coffee b/extension/packages/vim.coffee index 19122d9..6e0f87b 100644 --- a/extension/packages/vim.coffee +++ b/extension/packages/vim.coffee @@ -28,7 +28,6 @@ class Vim onInput: (keyStr, event) -> isEditable = utils.isElementEditable(event.originalTarget) - if (isEditable or @rootWindow.TabView.isVisible()) \ and not (isEscCommandKey(keyStr) or isReturnCommandKey(keyStr)) return false -- 2.39.3