From a6b54b416ab39801bdc234afdd01ebe9af10daf3 Mon Sep 17 00:00:00 2001 From: Simon Lydell Date: Thu, 15 Sep 2016 17:11:50 +0200 Subject: [PATCH] Always treat the hint chars' case as-is Since filtering hint markers by element text isn't available for the `eb` command, the hint chars were previously treated as case insensitive for that command. Similarly, they were also treated as case insensitive when disabling the `hints.match_text` option. However, the above led to numerous bugs. This commit simply gets rid of that behavior, and keeps the hint chars consistent across all `f` commands and options instead. --- extension/lib/commands.coffee | 4 +--- extension/lib/hints-mode.coffee | 1 - 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/extension/lib/commands.coffee b/extension/lib/commands.coffee index 104ffbc..76dbcb0 100644 --- a/extension/lib/commands.coffee +++ b/extension/lib/commands.coffee @@ -691,11 +691,9 @@ commands.click_browser_element = ({vim}) -> if wrappers.length > 0 viewport = viewportUtils.getWindowViewport(window) - hintChars = - utils.removeDuplicateChars(vim.options['hints.chars'].toLowerCase()) markerContainer = new MarkerContainer({ window - hintChars + hintChars: vim.options['hints.chars'] adjustZoom: false getComplementaryWrappers: (callback) -> newWrappers = markableElements.find( diff --git a/extension/lib/hints-mode.coffee b/extension/lib/hints-mode.coffee index f1cf6c3..ae343f8 100644 --- a/extension/lib/hints-mode.coffee +++ b/extension/lib/hints-mode.coffee @@ -67,7 +67,6 @@ cleanup = (vim, storage) -> getChar = (match, {markerContainer, matchText}) -> {unmodifiedKey} = match - unmodifiedKey = unmodifiedKey.toLowerCase() unless matchText isHintChar = switch when not matchText -- 2.39.3