From c6da3d75ed83804ac75c8c051eaa5700825743c1 Mon Sep 17 00:00:00 2001 From: Simon Lydell Date: Sun, 15 Nov 2015 20:06:57 +0100 Subject: [PATCH] Enable the `missing_fat_arrow` coffeelint rule To prevent mistakes like the one fixed in commit 5d2a01bf5. --- coffeelint.json | 2 +- extension/bootstrap.coffee | 2 +- extension/lib/prefs.coffee | 5 +++-- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/coffeelint.json b/coffeelint.json index b793699..07264e9 100644 --- a/coffeelint.json +++ b/coffeelint.json @@ -12,7 +12,7 @@ "indentation": {"level": "error", "value": 2}, "line_endings": {"level": "error", "value": "unix"}, "max_line_length": {"level": "warn", "value": 80}, - "missing_fat_arrows": {"level": "ignore"}, + "missing_fat_arrows": {"level": "error"}, "newlines_after_classes": {"level": "ignore"}, "no_backticks": {"level": "error"}, "no_debugger": {"level": "error"}, diff --git a/extension/bootstrap.coffee b/extension/bootstrap.coffee index 9e9d8e5..ad52a85 100644 --- a/extension/bootstrap.coffee +++ b/extension/bootstrap.coffee @@ -99,7 +99,7 @@ do (global = this) -> migrations = require('./lib/migrations') prefs = require('./lib/prefs') - prefs.default._init() + prefs.default.init() applyMigrations(migrations) main = if IS_FRAME_SCRIPT then './lib/main-frame' else './lib/main' diff --git a/extension/lib/prefs.coffee b/extension/lib/prefs.coffee index ce95b46..dfce60c 100644 --- a/extension/lib/prefs.coffee +++ b/extension/lib/prefs.coffee @@ -84,8 +84,9 @@ module.exports = default: get: get.bind(null, branches.addon.default) set: set.bind(null, branches.addon.default) - _init: -> - @set(key, value) for key, value of defaults.all_prefs + init: -> + for key, value of defaults.all_prefs + module.exports.default.set(key, value) return root: get: get.bind(null, branches.root.user) -- 2.39.3