From da284b1adf7efcc541b16ac34f55bf9e0444a366 Mon Sep 17 00:00:00 2001 From: Anton Khodakivskiy Date: Thu, 6 Dec 2012 11:46:31 +0200 Subject: [PATCH] Closes 33. Now the container divs are appended directly to document.documentElement (html) This allows to avoid various edge cases (ex: body { position: relative; } --- extension/packages/help.coffee | 12 ++++++------ extension/packages/hints.coffee | 6 +++--- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/extension/packages/help.coffee b/extension/packages/help.coffee index cf2337a..52839e6 100644 --- a/extension/packages/help.coffee +++ b/extension/packages/help.coffee @@ -2,8 +2,12 @@ utils = require 'utils' CONTAINER_ID = 'VimFxHelpDialogContainer' +hideHelp = (document) -> + if div = document.getElementById CONTAINER_ID + div.parentNode.removeChild div + showHelp = (document, commandsHelp) -> - if body = document.body + if document.documentElement if div = document.getElementById CONTAINER_ID div.parentNode.removeChild div div = document.createElement 'div' @@ -12,7 +16,7 @@ showHelp = (document, commandsHelp) -> div.appendChild parseHTML(document, helpDialogHtml(commandsHelp)) - body.appendChild div + document.documentElement.appendChild div if button = document.getElementById('VimFxClose') clickHandler = (event) -> @@ -26,10 +30,6 @@ parseHTML = (doc, html) -> flags = parser.SanitizerAllowStyle return parser.parseFragment(html, flags, false, null, doc.documentElement) -hideHelp = (document) -> - if div = document.getElementById CONTAINER_ID - div.parentNode.removeChild div - td = (text, klass='') -> """#{ text }""" diff --git a/extension/packages/hints.coffee b/extension/packages/hints.coffee index 5cabd6b..7e4eb08 100644 --- a/extension/packages/hints.coffee +++ b/extension/packages/hints.coffee @@ -16,7 +16,7 @@ createHintsContainer = (document) -> injectHints = (document) -> removeHints document - if document instanceof HTMLDocument + if document instanceof HTMLDocument and document.documentElement markers = Marker.createMarkers document container = createHintsContainer document @@ -27,13 +27,13 @@ injectHints = (document) -> container.appendChild fragment - document.body.appendChild container + document.documentElement.appendChild container return markers removeHints = (document, markers) -> if container = getHintsContainer document - document.body.removeChild container + document.documentElement.removeChild container handleHintChar = (markers, char) -> -- 2.39.3