]> git.gir.st - VimFx.git/commit
Reduce unnecessary vertical code alignment
authorSimon Lydell <simon.lydell@gmail.com>
Fri, 19 Feb 2016 06:55:41 +0000 (07:55 +0100)
committerSimon Lydell <simon.lydell@gmail.com>
Fri, 19 Feb 2016 18:14:04 +0000 (19:14 +0100)
commit0f6ebda9a911aa2731cc18d694a5bf0b4de14b4b
tree9d1aa6fa10f21149875c1803893e4c31304b72ef
parent3d8c945b1a1c5c38e156d4794fcf53192d6daa6e
Reduce unnecessary vertical code alignment

While it may look nice many times, it causes annoying merge conflicts.
Especially aligning all `require(...)` calls has bitten me many times, since
adding or removing one often requires reformatting the entire block.

This commit attempts to remove vertical alignment (especially around `=`) for
the sake of smaller diffs and simpler merges.

Vertical alignment has been kept, though, where it really makes the code easier
to read and you're likely to edit all of the aligned lines anyway if changing
one of them. The most common example is code dealing with X and Y coordinates
and having to do the same thing to both of them. Only the words X, Y, left,
right, top, bottom, width, height etc. differ between the lines. It's easier to
see that they are really up-to-date with each other if the common parts are
aligned.
25 files changed:
extension/lib/api.coffee
extension/lib/button.coffee
extension/lib/commands-frame.coffee
extension/lib/commands.coffee
extension/lib/defaults.coffee
extension/lib/events-frame.coffee
extension/lib/events.coffee
extension/lib/help.coffee
extension/lib/hints.coffee
extension/lib/legacy.coffee
extension/lib/main-frame.coffee
extension/lib/main.coffee
extension/lib/marker.coffee
extension/lib/migrations.coffee
extension/lib/modes.coffee
extension/lib/options.coffee
extension/lib/parse-prefs.coffee
extension/lib/scrollable-elements.coffee
extension/lib/utils.coffee
extension/lib/vim-frame.coffee
extension/lib/vim.coffee
extension/lib/vimfx.coffee
extension/test/index.coffee
extension/test/test-api.coffee
gulpfile.coffee
Imprint / Impressum