]> git.gir.st - VimFx.git/commit
Fix issues with scrolling and frames
authorSimon Lydell <simon.lydell@gmail.com>
Sat, 14 Nov 2015 20:28:34 +0000 (21:28 +0100)
committerSimon Lydell <simon.lydell@gmail.com>
Sat, 14 Nov 2015 21:59:50 +0000 (22:59 +0100)
commitef5e236676be4190bf368bf4abe35fa60d59774d
tree1bdd11fbfe84cab056e2a0f9d29a7d888f50fa26
parentee9465eb0ea626990f73d7b55f3f0c3011375a32
Fix issues with scrolling and frames

Since commit 4958beb3b we use `MutationObserver`s to keep
`vim.state.scrollableElements` up-to-date when scrollable elements are removed.
However, there are two more ways elements can be removed if the are located
inside a frame:

- If the whole frame is removed.
- If the `src` attribute of the frame is changed.

This caused "TypeError: can't access dead object" errors on gmail.com.

This commit takes care of those two frame cases as well.

See #605.
extension/lib/commands-frame.coffee
extension/lib/events-frame.coffee
extension/lib/scrollable-elements.coffee [new file with mode: 0644]
extension/lib/utils.coffee
extension/lib/vim-frame.coffee
Imprint / Impressum