When hitting esc a TypeError was shown in the browser console
(Ctrl-Shift-J), except when an element is fullscreened. The location of
the error (i.e. commands-frame.js:621) is only shown on special pages
(like about:* or chrome://), making the problem harder to locate.
see also: functionality introduced in commit ab17744
> TypeError: The expression cannot be converted to return the specified type. commands-frame.js:621
Remove dependency on non-standard Array.some() and Array.filter()
Also replaces the deprecated DOMQuad.bounds.
Firefox 70 will remove[1] non-standard Array generics[2][3]. These were
identified using the following shell pipeline:
cd VimFx/extension
grep -rn 'Array\.' | grep -v '\.isArray\|\.of\|\.from\|\.prototype'
girst [Sun, 12 May 2019 13:15:30 +0000 (15:15 +0200)]
fix hintsmode clicking in ff56, squash some exceptions
Some uses of the deprecated Array.func() syntax are, despite the browser
console telling us, not replacable by Array.prototype.func(). Also
silenced some exceptions that are expected.
girst [Sun, 12 May 2019 12:35:27 +0000 (14:35 +0200)]
partial fix for `eb'
the vbox#browser-panel element was removed and its children
(#navigator-toolbox, #content-deck, ...) are now direct descendants of
the <window> element.
This fix allows selecting and clicking on an item in the toolbar, but
any drop down menus that then appear aren't clickable.
依云 [Sun, 19 Nov 2017 16:16:56 +0000 (00:16 +0800)]
support for nsPrefBranch::{get,set}StringPref() (#901)
Firefox commit:
--8<--
Bug 1414096 (attempt 2) - Remove support for nsISupportsString values in nsPrefBranch::{get,set}ComplexValue(). r=florian.
Bug 1345294 introduced nsPrefBranch::{get,set}StringPref(), which allowed the
getting of utf8 strings from prefs, which previously required using
nsISupportsString with {get,set}ComplexValue. That bug also converted most
uses.
This patch finishes the job.
- It removes the nsISupportsString support.
- It converts existing code that relied on the nsISupportsString.
- It removes the lint that was set up to detect such uses of nsISupportsString.
Simon Lydell [Tue, 10 Jan 2017 06:53:00 +0000 (07:53 +0100)]
Scroll closest scrollable parent
If you click a tweet on Twitter, a modal with the tweet as well as
responses to it pop up. That modal can be scrollable if there are enough
responses. The container for the main tweet is focused. It feels very
natural that the _modal_ should scroll when using VimFx commands, not
the page behind it. That used not to be the case, but now is. This was
implemented by not just checking if the active element _itself_ is
scrollable, but also whether one of its _parents_ are scrollable, and
using the closest scrollable parent (if any).
Interleaved [Fri, 16 Dec 2016 09:14:43 +0000 (10:14 +0100)]
Update de locale (#845)
* Update de translation for blacklist settings
Use word "Ausnahmen" ("Exception") for the blacklist description instead of using "Schwarze Liste". It could be considered to use "Exeptions" also for the english locale.
* Update de translation for auto activation
* Add more de translations
Tabs is also used mostly in german. Sometimes the word "Registerkarten" is used for that.
Simon Lydell [Sun, 4 Dec 2016 14:48:04 +0000 (15:48 +0100)]
Fix tests in Firefox Nightly
Firefox have either moved the Assert.jsm module, or stopped exposing it.
I'm tired of that happening (it's not the first time), so I decided to
implement the small part of Assert.jsm that was actually used in VimFx's
test on my own. On the upside, this resulted in nicer error messages
when tests fail.
Simon Lydell [Sun, 13 Nov 2016 16:47:19 +0000 (17:47 +0100)]
Always place markers next to text if appropriate
For example, the hint marker for buttons with centered text are now
placed just to the left of the text rather than at the left edge of
button. This is nice because it means that hint markers usually end up
where you were just reading.